Move to a callback-style approach to deserializing objects (part2) #72944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 8, 2024
|
|
||
| await this.SynchronizeAssetsAsync(assetPath, checksums, results, cancellationToken).ConfigureAwait(false); | ||
|
|
||
| var result = new (Checksum checksum, T asset)[checksums.Count]; |
There was a problem hiding this comment.
no intermediary alloc!
CyrusNajmabadi
commented
Apr 8, 2024
| @@ -218,14 +218,15 @@ static SourceGeneratorExecutionVersionMap FilterToProjectCone(SourceGeneratorExe | |||
| using var _5 = PooledHashSet<Checksum>.GetInstance(out var newChecksumsToSync); | |||
| newChecksumsToSync.AddRange(newProjectIdToChecksum.Values); | |||
|
|
|||
| var newProjectStateChecksums = await _assetProvider.GetAssetsAsync<ProjectStateChecksums>( | |||
| assetPath: AssetPath.SolutionAndTopLevelProjectsOnly, newChecksumsToSync, cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
instead of having to allocate into this array, just to copy those all out and put into a dictionary below, we can now just read things right into the dictionary itself :)
CyrusNajmabadi
commented
Apr 8, 2024
| @@ -503,14 +504,15 @@ private async Task<Project> UpdateProjectInfoAsync(Project project, Checksum inf | |||
| using var _5 = PooledHashSet<Checksum>.GetInstance(out var newChecksumsToSync); | |||
| newChecksumsToSync.AddRange(newDocumentIdToChecksum.Values); | |||
|
|
|||
| var documentStateChecksums = await _assetProvider.GetAssetsAsync<DocumentStateChecksums>( | |||
|
@ToddGrun ptal :) |
ToddGrun
reviewed
Apr 9, 2024
| using System.Collections.Generic; | ||
| using System.Collections.Immutable; | ||
| using System.Runtime.InteropServices; |
ToddGrun
reviewed
Apr 9, 2024
ToddGrun
reviewed
Apr 9, 2024
ToddGrun
reviewed
Apr 9, 2024
This was referenced Apr 13, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to removing even more intermediary allocs, as well as allowing our lambdas to be static through the use of an
TArgvalue passed along.