Fix certain solution asserts. #73195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
Apr 23, 2024
| @@ -486,6 +486,9 @@ public static ProjectStateChecksums Deserialize(ObjectReader reader) | |||
| await ChecksumCollection.FindAsync(assetPath, state.AnalyzerConfigDocumentStates, searchingChecksumsLeft, onAssetFound, arg, cancellationToken).ConfigureAwait(false); | |||
| } | |||
| } | |||
|
|
|||
| public override string ToString() | |||
There was a problem hiding this comment.
yes. i personally don't care one way or hte other. it's all internal types, so ToString seems entirely reasonable to me.
There was a problem hiding this comment.
Yep, I'm fine either way. Whenever I see a ToString, I'm never certain if it's there for debugging or for actually having it's value being used in the code.
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.