Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle labels in outer scope in control flow pass #73234

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Handle labels in outer scope in control flow pass #73234

merged 2 commits into from
Apr 30, 2024

Conversation

jjonescz
Copy link
Member

Fixes #73068.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 25, 2024
@jjonescz jjonescz marked this pull request as ready for review April 26, 2024 09:46
@jjonescz jjonescz requested a review from a team as a code owner April 26, 2024 09:46
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

jcouv
jcouv approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1) with minor comment

@jcouv jcouv self-assigned this Apr 26, 2024
@jaredpar jaredpar added this to the 17.11 milestone Apr 28, 2024
@jjonescz jjonescz requested a review from AlekseyTs April 29, 2024 09:04
AlekseyTs
AlekseyTs approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@jjonescz jjonescz merged commit 5e95dce into dotnet:main Apr 30, 2024
24 checks passed
@jjonescz jjonescz deleted the 73068-GotoFromLambda branch April 30, 2024 06:07
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 17.11, Next Apr 30, 2024
@dotnet-bot dotnet-bot mentioned this pull request May 14, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 21, 2024
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.

KeyNotFoundException during compilation of goto that leaves lambda
5 participants
@jjonescz @AlekseyTs @jcouv @jaredpar @Cosifne