Allow use of more Hot Reload brokered services by LSP (for VS Code) #73240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
Add the HotReloadOptionService and HotReloadLoggerService to the list of remote brokered services that are registered, allowing use of those services by MAUI Hot Reload in VS Code. Both of these Hot Reload services are proffered by vs-green debugger functionality, implemented in TypeScript there.
BretJohnson
force-pushed
the
dev/bretjohn/include-more-brokered-services
branch
from
c287963
to
a0375ce
Compare
|
cc @dibarbet |
dibarbet
approved these changes
Apr 26, 2024
|
@CyrusNajmabadi - do you want to review as well? should be quick; thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the HotReloadOptionService and HotReloadLoggerService to the list of remote brokered services that are registered, allowing use of those services by MAUI Hot Reload in VS Code. Both of these Hot Reload services are proffered by vs-green debugger functionality, implemented in TypeScript there.
These changes need to be in VS Code before the functionality here
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/546989,
that depends on them, can work.