Switch to static local functions

src/EditorFeatures/CSharpTest/Formatting/CodeCleanupTests.cs

@@ -841,7 +841,7 @@ private static string[] GetSupportedDiagnosticIdsForCodeCleanupService(string la
             var supportedDiagnostics = enabledDiagnostics.Diagnostics.SelectMany(x => x.DiagnosticIds).ToArray();
             return supportedDiagnostics;
 
-            EditorTestWorkspace GetTestWorkspaceForLanguage(string language)
+            static EditorTestWorkspace GetTestWorkspaceForLanguage(string language)
             {
                 if (language == LanguageNames.CSharp)
                 {

src/EditorFeatures/Core.Wpf/Lightup/LightupHelpers.cs

@@ -377,7 +377,7 @@ TResult FallbackAccessor(T instance)
 
     private static Action<T> CreateFallbackAction<T>()
     {
-        void FallbackAction(T instance)
+        static void FallbackAction(T instance)
         {
             if (instance == null)
             {
@@ -392,7 +392,7 @@ void FallbackAction(T instance)
 
     private static Action<T, TArg> CreateFallbackAction<T, TArg>()
     {
-        void FallbackAction(T instance, TArg arg)
+        static void FallbackAction(T instance, TArg arg)
         {
             if (instance == null)
             {

src/EditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionOrUserDiagnosticTest.cs

@@ -259,7 +259,7 @@ private static void AddAnalyzerConfigDocumentWithOptions(EditorTestWorkspace wor
             Assert.True(applied);
             return;
 
-            string GenerateAnalyzerConfigText(OptionsCollectionAlias options)
+            static string GenerateAnalyzerConfigText(OptionsCollectionAlias options)
             {
                 var textBuilder = new StringBuilder();
 

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/MissingAssemblyTests.cs

@@ -475,7 +475,7 @@ public void ShouldTryAgain_ObjectDisposedException()
         [Fact]
         public void ShouldTryAgain_RPC_E_DISCONNECTED()
         {
-            IntPtr gmdbpf(AssemblyIdentity assemblyIdentity, out uint uSize)
+            static IntPtr gmdbpf(AssemblyIdentity assemblyIdentity, out uint uSize)
             {
                 Marshal.ThrowExceptionForHR(unchecked((int)0x80010108));
                 throw ExceptionUtilities.Unreachable();
@@ -489,7 +489,7 @@ IntPtr gmdbpf(AssemblyIdentity assemblyIdentity, out uint uSize)
         [Fact]
         public void ShouldTryAgain_Exception()
         {
-            IntPtr gmdbpf(AssemblyIdentity assemblyIdentity, out uint uSize)
+            static IntPtr gmdbpf(AssemblyIdentity assemblyIdentity, out uint uSize)
             {
                 throw new Exception();
             }

src/ExpressionEvaluator/Core/Test/ExpressionCompiler/ExpressionCompilerTestHelpers.cs

@@ -547,7 +547,7 @@ internal static void VerifyResolutionRequests(EEMetadataReferenceResolver resolv
             actual.Free();
             expected.Free();
 
-            void sort(ArrayBuilder<(AssemblyIdentity, AssemblyIdentity, int)> builder)
+            static void sort(ArrayBuilder<(AssemblyIdentity, AssemblyIdentity, int)> builder)
             {
                 builder.Sort((x, y) => AssemblyIdentityComparer.SimpleNameComparer.Compare(x.Item1.GetDisplayName(), y.Item1.GetDisplayName()));
             }

src/Features/CSharp/Portable/Completion/CompletionProviders/PropertySubPatternCompletionProvider.cs

@@ -196,7 +196,7 @@ private static (PropertyPatternClauseSyntax?, ExpressionSyntax?) TryGetPropertyP
 
         return default;
 
-        bool IsExtendedPropertyPattern(MemberAccessExpressionSyntax memberAccess, [NotNullWhen(true)] out PropertyPatternClauseSyntax? propertyPatternClause)
+        static bool IsExtendedPropertyPattern(MemberAccessExpressionSyntax memberAccess, [NotNullWhen(true)] out PropertyPatternClauseSyntax? propertyPatternClause)
         {
             while (memberAccess.Parent.IsKind(SyntaxKind.SimpleMemberAccessExpression))
             {

src/Features/CSharpTest/GenerateComparisonOperators/GenerateComparisonOperatorsTests.cs

@@ -401,7 +401,7 @@ class C : IComparable<C>, IComparable<int>
                 [||]
                 }
                 """;
-            string GetFixedCode(string type)
+            static string GetFixedCode(string type)
 => $@"using System;
 
 class C : IComparable<C>, IComparable<int>

src/Features/DiagnosticsTestUtilities/CodeActionsLegacy/AbstractCodeActionOrUserDiagnosticTest_NoEditor.cs

@@ -262,7 +262,7 @@ private static void AddAnalyzerConfigDocumentWithOptions(TestWorkspace workspace
             Assert.True(applied);
             return;
 
-            string GenerateAnalyzerConfigText(OptionsCollectionAlias options)
+            static string GenerateAnalyzerConfigText(OptionsCollectionAlias options)
             {
                 var textBuilder = new StringBuilder();
 

src/Tools/BuildBoss/SolutionCheckerUtil.cs

@@ -109,7 +109,7 @@ private bool CheckDuplicate(TextWriter textWriter, out Dictionary<ProjectKey, So
         /// </summary>
         private bool CheckProjectSystemGuid(TextWriter textWriter, IEnumerable<SolutionProjectData> dataList)
         {
-            Guid getExpectedGuid(ProjectData data)
+            static Guid getExpectedGuid(ProjectData data)
             {
                 var util = data.ProjectUtil;
                 switch (ProjectEntryUtil.GetProjectFileType(data.FilePath))

src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/InteractiveWindowInProcess.cs

@@ -259,7 +259,7 @@ public async Task VerifyTagsAsync<TTag>(int expectedCount, CancellationToken can
 
             var view = await GetActiveTextViewAsync(cancellationToken);
 
-            bool filterTag(IMappingTagSpan<ITag> tag)
+            static bool filterTag(IMappingTagSpan<ITag> tag)
             {
                 return tag.Tag.GetType().Equals(typeof(TTag));
             }

src/Workspaces/Core/Portable/Serialization/SerializerService_Reference.cs

@@ -554,7 +554,7 @@ public override string ToString()
                 Guids={modules.Select(m => GetMetadataGuid(m).ToString()).Join(",")}
             """;
 
-            ImmutableArray<ModuleMetadata> GetModules(Metadata? metadata)
+            static ImmutableArray<ModuleMetadata> GetModules(Metadata? metadata)
             {
                 if (metadata is AssemblyMetadata assemblyMetadata)
                 {

src/Workspaces/CoreTest/ObjectSerializationTests.cs

@@ -596,7 +596,7 @@ private static void TestRoundTripChar(Char ch)
         [Fact]
         public void TestRoundTripGuid()
         {
-            void test(Guid guid)
+            static void test(Guid guid)
             {
                 TestRoundTrip(guid, (w, v) => w.WriteGuid(v), r => r.ReadGuid());
             }

src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs

@@ -70,7 +70,7 @@ public async Task WithReferencesMethodCorrectlyUpdatesWithEqualReferences(TestHo
             // reference with another reference that's equal, we correctly update generators. We'll have the underlying generators
             // be different since two AnalyzerFileReferences that are value equal but different instances would have their own generators as well.
             const string SharedPath = "Z:\\Generator.dll";
-            ISourceGenerator CreateGenerator() => new SingleFileTestGenerator("// StaticContent", hintName: "generated");
+            static ISourceGenerator CreateGenerator() => new SingleFileTestGenerator("// StaticContent", hintName: "generated");
 
             var analyzerReference1 = new TestGeneratorReferenceWithFilePathEquality(CreateGenerator(), SharedPath);
             var analyzerReference2 = new TestGeneratorReferenceWithFilePathEquality(CreateGenerator(), SharedPath);