Update features to fork solution once instead of forking once per changed document. #73396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 9, 2024
| produceItems: static async (document, callback, fallbackOptions, cancellationToken) => | ||
| { | ||
| if (await document.IsGeneratedCodeAsync(cancellationToken).ConfigureAwait(false)) | ||
| return; |
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
May 9, 2024
| document = await RemoveUnnecessaryImportsWorkerAsync( | ||
| document, | ||
| CreateImports(document, names, withFormatterAnnotation: false), | ||
| cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
this was wacky. we were updating the documents serially, and then doing a parallel processing of it below.
CyrusNajmabadi
commented
May 9, 2024
| where TDocumentState : TextDocumentState | ||
| { | ||
| return UpdateDocumentsInMultipleProjects(projectIdAndNewDocuments, addDocumentsToProjectState); | ||
| } |
CyrusNajmabadi
commented
May 9, 2024
| => oldDocument.TryGetText(out var oldText) && text == oldText; | ||
| } | ||
|
|
||
| private SolutionCompilationState WithDocumentContents<TContent>( |
There was a problem hiding this comment.
added this helper used by WithDocumentTexts and WithDocumentSyntaxRoots
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
May 9, 2024
| @@ -241,17 +242,26 @@ CodeAction CreateNewCodeAction(string actionName, bool allOccurrences, Introduce | |||
| var rewriter = new IntroduceParameterDocumentRewriter(this, originalDocument, | |||
| expression, methodSymbol, containingMethod, selectedCodeAction, fallbackOptions, allOccurrences); | |||
There was a problem hiding this comment.
i checked, and rewriter should be safe to use concurrently from within produceItems below.
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.