Remove array allocations for formatting rules. #73458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 13, 2024
| @@ -30,10 +31,10 @@ internal static IEnumerable<AbstractFormattingRule> GetDefaultFormattingRules(IS | |||
| /// <param name="cancellationToken">An optional cancellation token.</param> | |||
| /// <returns>The formatted tree's root node.</returns> | |||
| public static SyntaxNode Format(SyntaxNode node, ISyntaxFormatting syntaxFormattingService, SyntaxFormattingOptions options, CancellationToken cancellationToken) | |||
| => Format(node, [node.FullSpan], syntaxFormattingService, options, rules: null, cancellationToken: cancellationToken); | |||
| => Format(node, [node.FullSpan], syntaxFormattingService, options, rules: default, cancellationToken: cancellationToken); | |||
There was a problem hiding this comment.
changed things to be explicitly ImmutableArrays, not IEnumerables. So lots of fallout of that.
CyrusNajmabadi
commented
May 13, 2024
| @@ -45,21 +46,35 @@ internal abstract partial class AbstractFormatEngine | |||
| internal readonly SyntaxFormattingOptions Options; | |||
| internal readonly TreeData TreeData; | |||
|
|
|||
| private static readonly object s_gate = new(); | |||
| private static (ImmutableArray<AbstractFormattingRule> formattingRules, SyntaxFormattingOptions options, ChainedFormattingRules chainedRules) s_lastRulesAndOptions; | |||
There was a problem hiding this comment.
this is the crux of hte change.
CyrusNajmabadi
commented
May 13, 2024
| } | ||
|
|
||
| return true; | ||
| }).ToImmutableArray(); | ||
| }); |
There was a problem hiding this comment.
i want an analyzer for this.
ToddGrun
reviewed
May 13, 2024
...table/GenerateEqualsAndGetHashCodeFromMembers/AbstractGenerateEqualsAndGetHashCodeService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
May 13, 2024
...kspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/Engine/AbstractFormatEngine.cs
Outdated
Show resolved
Hide resolved
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes effectively all of these allocatinos: