Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid enumeration allocations in formatting #73475

Merged
merged 6 commits into from
May 15, 2024

Conversation

CyrusNajmabadi
Copy link
Member

This shows up as 0.6% of all our allocs:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 14, 2024 22:18
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 14, 2024
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 256ed5b into dotnet:main May 15, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 15, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the formatTesting2 branch May 15, 2024 04:21
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants