Follow up on merge of ref-unsafe-in-iterators-async feature #73502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
jaredpar
reviewed
May 16, 2024
| IL_0031: leave.s IL_0033 | ||
| } | ||
| IL_0033: ldloca.s V_1 | ||
| IL_0035: constrained. ""S2"" |
There was a problem hiding this comment.
Interesting. I didn't realize constrained calls worked in non generics. #Resolved
There was a problem hiding this comment.
Interesting. I didn't realize constrained calls worked in non generics.
That is the way to call interface methods on structs without boxing
jjonescz
approved these changes
May 16, 2024
|
|
||
| comp.VerifyDiagnostics( | ||
| // PROTOTYPE(RefStructInterfaces): follow up on recent changes due to https://github.com/dotnet/csharplang/blob/main/proposals/ref-unsafe-in-iterators-async.md | ||
| // (18,22): error CS9104: A using statement resource of type 'S2' cannot be used in async methods or async lambda expressions. |
There was a problem hiding this comment.
Consider keeping this verification for LangVersion=12 #Resolved
There was a problem hiding this comment.
Consider keeping this verification for LangVersion=12
I do not find that particularly interesting for the scenarios tested in this PR because the ref-struct-interfaces feature isn't supported in C# 12 either.
AlekseyTs
merged commit b34c41a
into
dotnet:features/RefStructInterfaces
24 checks passed
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.