Allow razor to override RazorDesignTimeTargets to ones shipped with tooling instead of the sdk #73524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooling instead of the sdk
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
davidwengier
approved these changes
May 16, 2024
dibarbet
approved these changes
May 16, 2024
| @@ -96,7 +103,7 @@ public async Task OpenSolutionAsync(string solutionFilePath) | |||
|
|
|||
| // We'll load solutions out-of-proc, since it's possible we might be running on a runtime that doesn't have a matching SDK installed, | |||
| // and we don't want any MSBuild registration to set environment variables in our process that might impact child processes. | |||
| await using var buildHostProcessManager = new BuildHostProcessManager(loggerFactory: _loggerFactory); | |||
| await using var buildHostProcessManager = new BuildHostProcessManager(globalMSBuildProperties: AdditionalProperties, loggerFactory: _loggerFactory); | |||
There was a problem hiding this comment.
nice, didn't realize we already set this.
There was a problem hiding this comment.
Yea, made it way easier to add :)
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roslyn side of dotnet/razor#10351
See dotnet/razor#10377
Will also require a dual insertion and vs code updates