Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up a couple places that create a buffer or sourcetext from strings #73537

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix up a couple places that create a buffer or sourcetext from strings #73537

merged 1 commit into from
May 17, 2024

Conversation

ToddGrun
Copy link
Contributor

For SourceText->ITextBuffer, use ITextBufferCloneService.Clone
For ITextSnapshot -> SourceText, use ITextSnaphshot.AsText extension method

@ToddGrun
Fix up a couple places that create a buffer or sourcetext from strings
f039dc3 
For SourceText->ITextBuffer, use ITextBufferCloneService.Clone
For ITextSnapshot -> SourceText, use ITextSnaphshot.AsText extension method
@ToddGrun ToddGrun requested a review from a team as a code owner May 17, 2024 12:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 17, 2024
@ToddGrun ToddGrun merged commit 444a029 into dotnet:main May 17, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 17, 2024
This was referenced May 21, 2024
Closed
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@ToddGrun @CyrusNajmabadi @Cosifne