Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report diagnostic for field and value identifiers in property accessors where the meaning would change as contextual keywords #73570

Merged
merged 16 commits into from
Jun 5, 2024

Address feedback

435a126
Select commit
Loading
Failed to load commit list.
Merged

Report diagnostic for field and value identifiers in property accessors where the meaning would change as contextual keywords #73570

Address feedback
435a126
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Jun 4, 2024 in 0s

.NET Result Analysis

Details

All checks completed

✅ [roslyn-CI]

Build Rerun

✔️ Build passed after 1 retries.

(Attempt #1) [link to build]

roslyn-CI / Windows_Debug_Desktop / Test_Windows_Desktop_Debug_64 / Run Unit Tests

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌(NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed
    ❌PowerShell exited with code '1'.

roslyn-CI / Windows_Release_Desktop / Test_Windows_Desktop_Release_32 / Run Unit Tests

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌(NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed
    ❌PowerShell exited with code '1'.

Non-Deterministic Test Failures Detected

❌ Microsoft.CodeAnalysis.LanguageServer.Protocol.UnitTests_71.WorkItemExecution [Console] [Details] [Artifacts] [10.00% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

Failing Configuration
❌ Microsoft.CodeAnalysis.LanguageServer.Protocol.UnitTests_Microsoft.CodeAnalysis.LanguageServerIndexFormat.Generator.UnitTests_Microsoft.CodeAnalysis.R..._45.WorkItemExecution [Console] [Details] [Artifacts] [2.08% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

Failing Configuration
❌ Microsoft.CodeAnalysis.LanguageServer.UnitTests.Diagnostics.PullDiagnosticTests.TestWorkspaceDiagnosticsWaitsForLspTextChangesWithMultipleSources [Console] [Details] [Artifacts] [3.50% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

Failing Configuration

Was this helpful? Yes No

View more details on Build Analysis