Switch FAR data from an immutable dictionary to an immutable array #73587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
May 20, 2024
src/EditorFeatures/Core/LanguageServer/EditorLspReferencesResultCreationService.cs
Show resolved
Hide resolved
ToddGrun
reviewed
May 20, 2024
ToddGrun
reviewed
May 20, 2024
| { | ||
| additionalProperties.Add(containingMemberProperty); | ||
| if (node != null) |
There was a problem hiding this comment.
preserving existing code. and yes, it looks like it calls a helper that can return null.
CyrusNajmabadi
commented
May 20, 2024
src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/AbstractReferenceFinder.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 20, 2024
src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/AbstractReferenceFinder.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 20, 2024
Comment on lines
795
to
801
| //private static bool TryGetAdditionalProperty(string propertyName, ISymbol symbol, out KeyValuePair<string, string> additionalProperty) | ||
| //{ | ||
| // if (symbol == null) | ||
| // { | ||
| // additionalProperty = default; | ||
| // return false; | ||
| // } |
There was a problem hiding this comment.
Suggested change
| //private static bool TryGetAdditionalProperty(string propertyName, ISymbol symbol, out KeyValuePair<string, string> additionalProperty) | |
| //{ | |
| // if (symbol == null) | |
| // { | |
| // additionalProperty = default; | |
| // return false; | |
| // } |
ToddGrun
reviewed
May 20, 2024
| @@ -68,7 +69,7 @@ public async Task NavigateToAsync(NavigationOptions options, CancellationToken c | |||
| StandardTableKeyNames.Column => mappedSpanResult.LinePositionSpan.Start.Character, | |||
| StandardTableKeyNames.ProjectName => GetProjectName(), | |||
| StandardTableKeyNames.ProjectGuid => _boxedProjectGuid, | |||
| StandardTableKeyNames.Text => lineText.ToString().Trim(), | |||
| StandardTableKeyNames.Text => _trimmedLineText ??= lineText.ToString().Trim(), | |||
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit moves us from an expensive immutable dictionary to a simple immutable array. As this array only ever holds a max of two items, the dictionary was gross overkill.
Second commit avoids lock overhead in a common case where the FAR window repeatedly asks the same entities for data after we tell it to refresh.
This drops us from about 35Msecs computation time on the client to around 31Msecs