Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update partial properties feature branch from main #73774

Merged
merged 665 commits into from
May 30, 2024
Merged

Update partial properties feature branch from main #73774

merged 665 commits into from
May 30, 2024

Conversation

RikkiGibson
Copy link
Contributor

#73090

Interesting changes in 05ece7d

CyrusNajmabadi and others added 9 commits May 28, 2024 17:27
@CyrusNajmabadi
Update src/Features/Core/Portable/CodeRefactorings/CodeRefactoringSer…
0aac0b9 
…vice.cs
@Cosifne
Merge pull request dotnet#73754 from Cosifne/dev/shech/Snap17.11P2
bea7354 
Update config after snap 17.11 Preview 2
@CyrusNajmabadi
Merge pull request dotnet#73750 from CyrusNajmabadi/distinctIterator
9d15715
@ToddGrun
Change the DocumentationCommentId to use a PooledStringBuilder (dotne…
66d8f55 
…t#73737)

This shows as about 1% of allocations in OOP in a find references profile I'm looking at.
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-exter…
08c907e 
…nals build 20240528.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 9.0.0-alpha.1.24263.2 -> To Version 9.0.0-alpha.1.24278.2
@CyrusNajmabadi
Merge pull request dotnet#73758 from CyrusNajmabadi/parallelLightbulb
a775d93 
Run providers in parallel when determining if we should show the lightbulb icon
@Cosifne
Merge pull request dotnet#73764 from dotnet/darc-main-d8ea759a-507a-4…
90f65c7 
…547-9e5c-18c86525e11a

[main] Update dependencies from dotnet/source-build-externals
@RikkiGibson
Merge remote-tracking branch 'upstream/main' into partial-properties-9
73f258c
@RikkiGibson
Resolve conflicts
05ece7d
@RikkiGibson RikkiGibson requested review from a team as code owners May 29, 2024 20:08
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 29, 2024
@RikkiGibson RikkiGibson changed the base branch from main to features/partial-properties May 29, 2024 20:08
@RikkiGibson RikkiGibson requested review from a team as code owners May 29, 2024 20:08
@RikkiGibson RikkiGibson removed request for a team May 29, 2024 21:26
@RikkiGibson
Copy link
Contributor Author

@dotnet/roslyn-compiler for a fairly small/straightforward review

jcouv
jcouv approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 665). Only last commit looked at (conflicts)

@RikkiGibson RikkiGibson merged commit 4793dce into dotnet:features/partial-properties May 30, 2024
28 checks passed
@RikkiGibson RikkiGibson deleted the partial-properties-9 branch May 30, 2024 01:16
This was referenced Jun 4, 2024
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@RikkiGibson @jcouv @CyrusNajmabadi @JoeRobich @ToddGrun @DoctorKrolic @sharwell @Cosifne @dotnet-bot @tmat