Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MicrosoftCodeAnalysisTestingVersion to 1.1.2-beta1.24121.1 #73840

Conversation

akhera99
Copy link
Member

@akhera99 akhera99 commented Jun 4, 2024

Cherry-pick of #73831, with some additional error fixes.

@akhera99 akhera99 requested a review from arunchndr June 4, 2024 17:40
@akhera99 akhera99 requested review from a team as code owners June 4, 2024 17:40
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 4, 2024
@@ -4,7 +4,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<RootNamespace>Microsoft.CodeAnalysis.LanguageServerIndexFormat.Generator</RootNamespace>
<TargetFrameworks>net6.0;net472</TargetFrameworks>
<TargetFrameworks>net7.0;net472</TargetFrameworks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how we can make this change in the servicing branch. What limitation is causing the versions of packages outside the testing package to change?

@akhera99 akhera99 requested a review from sharwell June 11, 2024 17:41
@akhera99 akhera99 dismissed sharwell’s stale review June 12, 2024 16:47

updates made in another PR

@akhera99
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@akhera99
Copy link
Member Author

@dotnet-policy-service rerun

@akhera99 akhera99 merged commit ac1154a into dotnet:release/dev17.6 Jun 13, 2024
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants