Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply editorconfig settings to moved ExternalAccess #73896

Merged
merged 3 commits into from
Jun 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -284,3 +284,20 @@ dotnet_diagnostic.IDE2006.severity = warning
# CA1822: Make member static
# There is a risk of accidentally breaking an internal API that partners rely on though IVT.
dotnet_code_quality.CA1822.api_surface = private

[**/{ExternalAccess}/**/*.{cs,vb}]

# RS0016: Only enable if API files are present
dotnet_public_api_analyzer.require_api_files = true

dotnet_diagnostic.RS0051.severity = error
dotnet_diagnostic.RS0052.severity = error
dotnet_diagnostic.RS0053.severity = error
dotnet_diagnostic.RS0054.severity = error
dotnet_diagnostic.RS0055.severity = error
dotnet_diagnostic.RS0056.severity = error
dotnet_diagnostic.RS0057.severity = error
dotnet_diagnostic.RS0058.severity = error
dotnet_diagnostic.RS0059.severity = error
dotnet_diagnostic.RS0060.severity = error
dotnet_diagnostic.RS0061.severity = error
3 changes: 3 additions & 0 deletions src/EditorFeatures/ExternalAccess/Copilot/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[**]
dotnet_public_api_analyzer.skip_namespaces = Microsoft.CodeAnalysis.ExternalAccess.Copilot.Internal

2 changes: 2 additions & 0 deletions src/Features/ExternalAccess/AspNetCore/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[**]
dotnet_public_api_analyzer.skip_namespaces = Microsoft.CodeAnalysis.ExternalAccess.AspNetCore.Internal
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ private AspNetCoreCSharpRouteSyntaxDetector()
{
}

public static bool IsEmbeddedLanguageToken(
#pragma warning disable CA1822 // Mark members as static
public bool IsEmbeddedLanguageToken(
SyntaxToken token,
SemanticModel semanticModel,
CancellationToken cancellationToken,
Expand All @@ -39,4 +40,5 @@ public static bool IsEmbeddedLanguageToken(
{
return s_detector.IsEmbeddedLanguageToken(token, semanticModel, cancellationToken, out identifier, out options);
}
#pragma warning restore CA1822
}
2 changes: 2 additions & 0 deletions src/Features/ExternalAccess/OmniSharp/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[**]
dotnet_public_api_analyzer.skip_namespaces = Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Internal
41 changes: 0 additions & 41 deletions src/Tools/ExternalAccess/.editorconfig

This file was deleted.

4 changes: 4 additions & 0 deletions src/VisualStudio/ExternalAccess/Apex/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[**]

# RS0057: Symbol uses some oblivious reference types
dotnet_diagnostic.RS0057.severity = none
6 changes: 6 additions & 0 deletions src/VisualStudio/ExternalAccess/FSharp/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[**]

dotnet_public_api_analyzer.skip_namespaces = Microsoft.CodeAnalysis.ExternalAccess.FSharp.Internal

# RS0057: Symbol uses some oblivious reference types
dotnet_diagnostic.RS0057.severity = none
Loading