Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the last string's hash we computed in our filepath map #73937

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Cache the last string's hash we computed in our filepath map #73937

merged 4 commits into from
Jun 11, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Drops CPU cost in VS during solution load from:

image

to

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 11, 2024 15:17
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 11, 2024
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal.

ToddGrun
ToddGrun reviewed Jun 11, 2024
View reviewed changes
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.CachingFilePathComparer.cs Outdated
_lock.Exit();
}

if (ReferenceEquals(lastString, obj))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ReferenceEquals(lastString, obj))

Would it make things ugly to check _lastString against obj and only taking the lock if ReferenceEqual?

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Jun 11, 2024
Open
@CyrusNajmabadi CyrusNajmabadi merged commit f2705c0 into dotnet:main Jun 11, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 11, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the cacheHash branch June 11, 2024 18:33
This was referenced Jun 12, 2024
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @jjonescz