Remove fallbacks #74041
Merged
Remove fallbacks #74041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
tmat
force-pushed
the
RemoveFallbacks1
branch
2 times, most recently
from
538d7a6 to
fc441c2
Compare
3 tasks
tmat
force-pushed
the
RemoveFallbacks1
branch
3 times, most recently
from
df2991f to
fd80d9d
Compare
Open
3 tasks
|
|
|
Who do you think you are? Me? |
tmat
force-pushed
the
RemoveFallbacks1
branch
2 times, most recently
from
c586cc1 to
f523bf8
Compare
| }; | ||
|
|
||
| public static CleanCodeGenerationOptions GetCleanCodeGenerationOptions(this IOptionsReader options, LanguageServices languageServices, bool? allowImportsInHiddenRegions, CleanCodeGenerationOptions? fallbackOptions) | ||
| public static CleanCodeGenerationOptions GetCleanCodeGenerationOptions(this IOptionsReader options, LanguageServices languageServices, bool? allowImportsInHiddenRegions = null) |
There was a problem hiding this comment.
would prefer non-optional parameters.
CyrusNajmabadi
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove options fallbacks.
Fixes
#60777
#60786