Reduce allocations in AbstractProjectExtensionProvider.FilterExtensions #74112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up reducing allocations in the profile where I repeatedly brough up a lightbulb by about 0.7%. 1) Got rid of an Enum.ToString that happened on each filtering. Instead changed the code that reads the mef attributes to convert from string -> enum. 2) Got rid of a a couple Contains calls which were allocating an enumerator 3) Got rid of some closures by using the args version of WhereAsArray and by creating a separate method to handle the CWT insertion.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Open
3 tasks
|
|
||
| bool ShouldIncludeExtension(TExtension extension) | ||
| static bool ShouldIncludeExtension(TExtension extension, (TextDocument, Func<TExportAttribute, ExtensionInfo>) args) |
There was a problem hiding this comment.
i have no problem with you inlining this method into WhereAsArray.
There was a problem hiding this comment.
Tried it, stared at it for a minute, and I personally like it better in the current form. Will gladly change it though if you feel fairly strongly or have an objective reason.
src/Features/Core/Portable/Common/AbstractProjectExtensionProvider.cs
Outdated
Show resolved
Hide resolved
|
|
||
| if (extensionInfo == null) | ||
| return true; | ||
|
|
||
| if (!extensionInfo.DocumentKinds.Contains(document.Kind.ToString())) | ||
| if (-1 == Array.IndexOf(extensionInfo.DocumentKinds, document.Kind)) |
There was a problem hiding this comment.
would prefer a < 0 check. even if doc'ed some apis end up returning different from -1.
src/Features/Core/Portable/Common/AbstractProjectExtensionProvider.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return new(kinds, attribute.DocumentExtensions); | ||
| } |
There was a problem hiding this comment.
can we not have a helper for this? (since it seems duplicated).
…ider.cs Co-authored-by: Cyrus Najmabadi <[email protected]>
…Provider_FilterExtensions' of https://github.com/toddgrun/roslyn into dev/toddgrun/ReduceAlocationsIn_AbstractProjectExtensionProvider_FilterExtensions
|
|
||
| internal class EnumArrayConverter | ||
| { | ||
| public static TEnum[] FromStringArray<TEnum>(string[] strings) where TEnum : struct |
There was a problem hiding this comment.
Suggested change
| public static TEnum[] FromStringArray<TEnum>(string[] strings) where TEnum : struct | |
| public static TEnum[] FromStringArray<TEnum>(string[] strings) where TEnum : struct, System.Enum |
There was a problem hiding this comment.
Nite: consider returning ImmutableArray instread if you don't need to mutate hte array.
|
|
||
| namespace Microsoft.CodeAnalysis.CodeFixesAndRefactorings; | ||
|
|
||
| internal class EnumArrayConverter |
There was a problem hiding this comment.
Suggested change
| internal class EnumArrayConverter | |
| internal static class EnumArrayConverter |
CyrusNajmabadi
approved these changes
Jun 26, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up reducing allocations in the profile where I repeatedly brough up a lightbulb by about 0.7%.
*** Prior allocations that no longer show up ***
