Consume new Razor EA #74134
Merged
Consume new Razor EA #74134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ryzngard
commented
Jun 28, 2024
| @@ -47,9 +43,9 @@ internal void Initialize() | |||
| return; | |||
| } | |||
|
|
|||
| _logger.LogTrace("Initializing the Razor workspace listener"); | |||
| _logger.LogTrace("Initializing the Razor workspace listener with pipe name {0}", pipeName); | |||
| _razorWorkspaceListener = new RazorWorkspaceListener(_loggerFactory); | |||
There was a problem hiding this comment.
@davidwengier not for right now, but is there a reason we don't just take a workspace in the constructor?
There was a problem hiding this comment.
No idea off the top of my head. Maybe left over from something we used to need to do to avoid a circular MEF dependency?
davidwengier
approved these changes
Jun 28, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roslyn side of dotnet/razor#10521