Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in SymbolDeclaredCompilationEvent #74250

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Reduce allocations in SymbolDeclaredCompilationEvent #74250

merged 2 commits into from
Jul 5, 2024

Commits on Jul 3, 2024

  1. Reduce allocations in SymbolDeclaredCompilationEvent 

    The SymbolDeclaredCompilationEvent ctor is showing up as 0.5% of allocations in vbcscompiler.exe in a customer profile I'm looking at. All these costs are attributable to the use of Lazy in this class. Instead, just use a nullable field, and accept the fact that during extremely high contention, it is possible for an ImmutableArray to be created multiple times.
    @ToddGrun
    ToddGrun committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    09ce93c View commit details
    Browse the repository at this point in the history

  2. Use default instead to indicate that _lazyCachedDeclaringReferences h… 

    …asn't been initialized
    @ToddGrun
    ToddGrun committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f69650d View commit details
    Browse the repository at this point in the history