Remove (already disabled) command handlers related to 'add suppression' menu command. #74266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jul 3, 2024
| public const int ErrorListSetSeverityInfo = 0x0126; | ||
| public const int ErrorListSetSeverityHidden = 0x0127; | ||
| public const int ErrorListSetSeverityNone = 0x0128; | ||
| public const int ErrorListSetSeverityDefault = 0x0129; |
There was a problem hiding this comment.
Command ids no longer used.
There was a problem hiding this comment.
nit: comment above could be updated
CyrusNajmabadi
commented
Jul 3, 2024
| @@ -228,7 +227,6 @@ protected override async Task LoadComponentsAsync(CancellationToken cancellation | |||
| // we need to load it as early as possible since we can have errors from | |||
| // package from each language very early | |||
| await this.ComponentModel.GetService<VisualStudioSuppressionFixService>().InitializeAsync(this).ConfigureAwait(false); | |||
| await this.ComponentModel.GetService<VisualStudioDiagnosticListTableCommandHandler>().InitializeAsync(this, cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
no need to initialize since we have no more custom commands here.
CyrusNajmabadi
commented
Jul 3, 2024
| } | ||
| } | ||
|
|
||
| private DiagnosticData? TryGetSingleSelectedEntry() |
There was a problem hiding this comment.
once this was inlined to return null, the rest fell out.
CyrusNajmabadi
commented
Jul 3, 2024
| } | ||
|
|
||
| var selectedDiagnostic = TryGetSingleSelectedEntry(); | ||
| if (selectedDiagnostic == null) |
There was a problem hiding this comment.
when TryGetSingleSelectedEntry returns null, this whole method is a no op. So it doesn't call SetSeverityHandlerAsync, which unwinds everything.
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups to #74264 and #74265.
We are tracking the request to supply this (through LSP) with #74228. The core code to still do this will exist, but we won't use these command handlers. This PR can also be looked at in case we think there's any interesting logic in the command handler we'd actually want to preserve.