-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use memory mapped files on non-windows #74339
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
src/Workspaces/Core/Portable/TemporaryStorage/TrivialTemporaryStorageService.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using System.IO; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using Microsoft.CodeAnalysis.Host; | ||
using Microsoft.CodeAnalysis.Text; | ||
|
||
namespace Microsoft.CodeAnalysis; | ||
|
||
internal sealed class TrivialTemporaryStorageService : ITemporaryStorageServiceInternal | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{ | ||
public static readonly TrivialTemporaryStorageService Instance = new(); | ||
|
||
private TrivialTemporaryStorageService() | ||
{ | ||
} | ||
|
||
public ITemporaryStorageStreamHandle WriteToTemporaryStorage(Stream stream, CancellationToken cancellationToken) | ||
{ | ||
var newStream = new MemoryStream(); | ||
stream.CopyTo(newStream); | ||
return new StreamStorage(newStream); | ||
} | ||
|
||
public ITemporaryStorageTextHandle WriteToTemporaryStorage(SourceText text, CancellationToken cancellationToken) | ||
{ | ||
return new TextStorage(text); | ||
} | ||
|
||
public Task<ITemporaryStorageTextHandle> WriteToTemporaryStorageAsync(SourceText text, CancellationToken cancellationToken) | ||
{ | ||
return Task.FromResult<ITemporaryStorageTextHandle>(new TextStorage(text)); | ||
} | ||
|
||
private sealed class StreamStorage : ITemporaryStorageStreamHandle | ||
{ | ||
private readonly MemoryStream _stream; | ||
|
||
public TemporaryStorageIdentifier Identifier { get; } | ||
|
||
public StreamStorage(MemoryStream stream) | ||
{ | ||
_stream = stream; | ||
Identifier = new TemporaryStorageIdentifier(Guid.NewGuid().ToString(), 0, _stream.Length); | ||
} | ||
|
||
public Stream ReadFromTemporaryStorage(CancellationToken cancellationToken) | ||
{ | ||
// Return a read-only view of the underlying buffer to prevent users from overwriting or directly | ||
// disposing the backing storage. | ||
return new MemoryStream(_stream.GetBuffer(), 0, (int)_stream.Length, writable: false); | ||
} | ||
} | ||
|
||
private sealed class TextStorage : ITemporaryStorageTextHandle | ||
{ | ||
private readonly SourceText _sourceText; | ||
|
||
public TemporaryStorageIdentifier Identifier { get; } | ||
|
||
public TextStorage(SourceText sourceText) | ||
{ | ||
_sourceText = sourceText; | ||
Identifier = new TemporaryStorageIdentifier(Guid.NewGuid().ToString(), 0, _sourceText.Length); | ||
} | ||
|
||
public SourceText ReadFromTemporaryStorage(CancellationToken cancellationToken) | ||
{ | ||
return _sourceText; | ||
} | ||
|
||
public Task<SourceText> ReadFromTemporaryStorageAsync(CancellationToken cancellationToken) | ||
{ | ||
return Task.FromResult(_sourceText); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit weird. the serializer service is almost only used for oop serialization - except its also used for create project parse option checksums on all platforms.
The TemporaryStorageService is not used in that case, so instantiating it lazily to avoid throwing when it attempts to convert to TemporaryStorageService