Remove diagnostic for 'value' as a contextual keyword

src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs

@@ -1549,10 +1549,7 @@ private BoundExpression BindIdentifier(
                 var members = ArrayBuilder<Symbol>.GetInstance();
                 Symbol symbol = GetSymbolOrMethodOrPropertyGroup(lookupResult, node, name, node.Arity, members, diagnostics, out isError, qualifierOpt: null);  // reports diagnostics in result.
 
-                if (symbol is not SynthesizedAccessorValueParameterSymbol { Name: "value" })
-                {
-                    ReportFieldOrValueContextualKeywordConflictIfAny(node, node.Identifier, diagnostics);
-                }
+                ReportFieldContextualKeywordConflictIfAny(node, node.Identifier, diagnostics);
 
                 if ((object)symbol == null)
                 {
@@ -1738,21 +1735,17 @@ void reportPrimaryConstructorParameterShadowing(SimpleNameSyntax node, Symbol sy
 
 #nullable enable
         /// <summary>
-        /// Report a diagnostic for a 'field' or 'value' identifier that the meaning will
+        /// Report a diagnostic for a 'field' identifier that the meaning will
         /// change when the identifier is considered a contextual keyword.
         /// </summary>
-        internal void ReportFieldOrValueContextualKeywordConflictIfAny(SyntaxNode syntax, SyntaxToken identifier, BindingDiagnosticBag diagnostics)
+        internal void ReportFieldContextualKeywordConflictIfAny(SyntaxNode syntax, SyntaxToken identifier, BindingDiagnosticBag diagnostics)
         {
             string name = identifier.Text;
-            switch (name)
+            if (name == "field" &&
+                ContainingMember() is MethodSymbol { MethodKind: MethodKind.PropertyGet or MethodKind.PropertySet, AssociatedSymbol: PropertySymbol { IsIndexer: false } })
             {
-                case "field" when ContainingMember() is MethodSymbol { MethodKind: MethodKind.PropertyGet or MethodKind.PropertySet, AssociatedSymbol: PropertySymbol { IsIndexer: false } }:
-                case "value" when ContainingMember() is MethodSymbol { MethodKind: MethodKind.PropertySet or MethodKind.EventAdd or MethodKind.EventRemove }:
-                    {
-                        var requiredVersion = MessageID.IDS_FeatureFieldAndValueKeywords.RequiredVersion();
-                        diagnostics.Add(ErrorCode.INF_IdentifierConflictWithContextualKeyword, syntax, name, requiredVersion.ToDisplayString());
-                    }
-                    break;
+                var requiredVersion = MessageID.IDS_FeatureFieldKeyword.RequiredVersion();
+                diagnostics.Add(ErrorCode.INF_IdentifierConflictWithContextualKeyword, syntax, name, requiredVersion.ToDisplayString());
             }
         }
 #nullable disable

src/Compilers/CSharp/Portable/CSharpResources.resx

@@ -7902,8 +7902,8 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
   <data name="IDS_FeatureRefUnsafeInIteratorAsync" xml:space="preserve">
     <value>ref and unsafe in async and iterator methods</value>
   </data>
-  <data name="IDS_FeatureFieldAndValueKeywords" xml:space="preserve">
-    <value>field and value keywords</value>
+  <data name="IDS_FeatureFieldKeyword" xml:space="preserve">
+    <value>field keyword</value>
   </data>
   <data name="ERR_RefLocalAcrossAwait" xml:space="preserve">
     <value>A 'ref' local cannot be preserved across 'await' or 'yield' boundary.</value>

src/Compilers/CSharp/Portable/Errors/MessageID.cs

@@ -288,7 +288,7 @@ internal enum MessageID
         IDS_FeatureRefStructInterfaces = MessageBase + 12844,
 
         IDS_FeaturePartialProperties = MessageBase + 12845,
-        IDS_FeatureFieldAndValueKeywords = MessageBase + 12846,
+        IDS_FeatureFieldKeyword = MessageBase + 12846,
 
         IDS_FeatureAllowsRefStructConstraint = MessageBase + 12847,
         IDS_OverloadResolutionPriority = MessageBase + 12848,
@@ -473,7 +473,7 @@ internal static LanguageVersion RequiredVersion(this MessageID feature)
 
                 // C# preview features.
                 case MessageID.IDS_FeatureRefStructInterfaces:
-                case MessageID.IDS_FeatureFieldAndValueKeywords:
+                case MessageID.IDS_FeatureFieldKeyword:
                     return LanguageVersion.Preview;
 
                 // C# 13.0 features.

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenTupleTest.cs

@@ -3918,7 +3918,7 @@ int P
         set
         {
             var t = (M(), value);
-            System.Console.Write(t.@value);
+            System.Console.Write(t.value);
         }
     }
 }

src/Compilers/CSharp/Test/Semantic/Semantics/SemanticErrorTests.cs

@@ -4010,9 +4010,6 @@ static void N(int q)
                 // (24,17): error CS0136: A local or parameter named 'value' cannot be declared in this scope because that name is used in an enclosing local scope to define a local or parameter
                 //             int value = 0; // CS0136
                 Diagnostic(ErrorCode.ERR_LocalIllegallyOverrides, "value").WithArguments("value").WithLocation(24, 17),
-                // (25,15): info CS9258: 'value' is a contextual keyword in property accessors starting in language version preview. Use '@value' instead.
-                //             M(value);
-                Diagnostic(ErrorCode.INF_IdentifierConflictWithContextualKeyword, "value").WithArguments("value", "preview").WithLocation(25, 15),
                 // (30,35): error CS0136: A local or parameter named 'q' cannot be declared in this scope because that name is used in an enclosing local scope to define a local or parameter
                 //         System.Func<int, int> f = q=>q; // 0136
                 Diagnostic(ErrorCode.ERR_LocalIllegallyOverrides, "q").WithArguments("q").WithLocation(30, 35));
@@ -4027,10 +4024,7 @@ static void N(int q)
                 Diagnostic(ErrorCode.ERR_LocalIllegallyOverrides, "y").WithArguments("y").WithLocation(9, 17),
                 // (24,17): error CS0136: A local or parameter named 'value' cannot be declared in this scope because that name is used in an enclosing local scope to define a local or parameter
                 //             int value = 0; // CS0136
-                Diagnostic(ErrorCode.ERR_LocalIllegallyOverrides, "value").WithArguments("value").WithLocation(24, 17),
-                // (25,15): info CS9258: 'value' is a contextual keyword in property accessors starting in language version preview. Use '@value' instead.
-                //             M(value);
-                Diagnostic(ErrorCode.INF_IdentifierConflictWithContextualKeyword, "value").WithArguments("value", "preview").WithLocation(25, 15));
+                Diagnostic(ErrorCode.ERR_LocalIllegallyOverrides, "value").WithArguments("value").WithLocation(24, 17));
         }
 
         [Fact]