Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithDocumentAttributes #74421

Merged
merged 1 commit into from
Jul 23, 2024
Merged

WithDocumentAttributes #74421

merged 1 commit into from
Jul 23, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 17, 2024 •
edited
Loading

Replace UpdateName, UpdateFilePath and UpdateFolders with WithDocumentAttributes.
Simplifies WithDocumentContents and renames it to more general UpdateDocumentsInMultipleProjects.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 17, 2024
@tmat tmat marked this pull request as ready for review July 17, 2024 21:32
@tmat tmat requested a review from a team as a code owner July 17, 2024 21:32
@tmat tmat changed the title With document attributes WithDocumentAttributes Jul 17, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 18, 2024
Open
3 tasks
ToddGrun
ToddGrun approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat tmat merged commit c8e88e5 into dotnet:main Jul 23, 2024
25 checks passed
@tmat tmat deleted the WithDocumentAttributes branch July 23, 2024 04:15
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 23, 2024
This was referenced Jul 24, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @ToddGrun @RikkiGibson