Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check constraints on methods which are not substituted #74487

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Don't check constraints on methods which are not substituted #74487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d662b6
Don't check constraints on methods which are not substituted
RikkiGibson Jul 22, 2024
be52445
Address feedback
RikkiGibson Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10562,7 +10562,7 @@ static bool isCandidateUnique(ref MethodSymbol? foundMethod, MethodSymbol candid

bool satisfiesConstraintChecks(MethodSymbol method)
{
if (method.Arity == 0)
if (method.Arity == 0 || method.TypeSubstitution is null)
Copy link
Contributor

@AlekseyTs AlekseyTs Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method.Arity == 0 || method.TypeSubstitution is null

!RequiresChecking(method)? #Closed

{
return true;
}
Expand Down
21 changes: 21 additions & 0 deletions src/Compilers/CSharp/Test/Symbol/Symbols/ExtensionMethodTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4139,5 +4139,26 @@ public static void M(this A s, ref int i) {}
// public A(int x, A a = new A().M(1)) { }
Diagnostic(ErrorCode.ERR_BadArgRef, "1").WithArguments("2", "ref").WithLocation(8, 37));
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/74404")]
public void Repro_74404()
{
var source = """
#nullable enable
class Foo<T>;
Copy link
Contributor

@AlekseyTs AlekseyTs Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foo

This word is getting flagged by Policheck tool #Closed

static class FooExt
{
public static void Bar<T>(this Foo<T> foo)
{
foo.Bar = 42;
}
}
""";
var comp = CreateCompilation(source);
comp.VerifyEmitDiagnostics(
// (7,9): error CS1656: Cannot assign to 'Bar' because it is a 'method group'
// foo.Bar = 42;
Diagnostic(ErrorCode.ERR_AssgReadonlyLocalCause, "foo.Bar").WithArguments("Bar", "method group").WithLocation(7, 9));
}
}
}