Fix crash in sighelp #74510
Fix crash in sighelp #74510
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -101,8 +101,8 @@ internal partial class Session | |||
| currentModel.Provider == provider && | |||
| currentModel.GetCurrentSpanInSubjectBuffer(disconnectedBufferGraph.SubjectBufferSnapshot).Span.Start == items.ApplicableSpan.Start && | |||
| currentModel.Items.IndexOf(currentModel.SelectedItem) == items.SelectedItemIndex && | |||
| currentModel.ArgumentIndex == items.ArgumentIndex && | |||
| currentModel.ArgumentCount == items.ArgumentCount && | |||
There was a problem hiding this comment.
renamed these to make the distinction clear. 'argument count' refferred to how many explicit argument syntax nodes are present in the code. 'argument index' was very badly named. It indicated 'this is the parameter in the actual symcol we think the user is currently on'
There was a problem hiding this comment.
note: the pr is almost entirely this rename. i call out anything that isn't just that.
| items.SyntacticArgumentCount, | ||
| items.ArgumentName, | ||
| selectedParameter: 0, | ||
| userSelected); |
There was a problem hiding this comment.
just renames + wrapping. no other change.
| model.SemanticParameterIndex, | ||
| model.SyntacticArgumentCount, | ||
| model.ArgumentName, | ||
| isCaseSensitive); |
There was a problem hiding this comment.
just renames + wrapping. no other change.
| int semanticParameterIndex, | ||
| int syntacticArgumentCount, | ||
| string name, | ||
| bool isCaseSensitive) |
There was a problem hiding this comment.
just renames + wrapping. no other change.
| public int SemanticParameterIndex { get; } | ||
|
|
||
| /// <inheritdoc cref="SignatureHelpItems.SyntacticArgumentCount"/> | ||
| public int SyntacticArgumentCount { get; } |
| if (argumentCount < argumentIndex) | ||
| { | ||
| throw new ArgumentException($"{nameof(argumentCount)} < {nameof(argumentIndex)}. {argumentCount} < {argumentIndex}", nameof(argumentIndex)); | ||
| } |
There was a problem hiding this comment.
this was the crux of hte bug. a check that literally made no sense. the number of syntactic arguments provided has no basis on which semantic parameter we think is teh right one to select. It's just information about the syntax tree, that's all.
|
Thanks for fixing, this was for me the #1 most annoying/visible Roslyn bug for my usage in the past year or maybe more. |
Fixes #72012
Fixes #74500
Fixes #74383