Cleanup LSP error reporting #74530
Merged
Cleanup LSP error reporting #74530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Jul 23, 2024
| { | ||
| if (rethrowExceptions) | ||
| { | ||
| return nonMutatingRequestTask; | ||
| try |
There was a problem hiding this comment.
fixes a bug here where we would only report NFW for non-mutating requests. If a mutating request failed we would never get fault telemetry for it.
dibarbet
commented
Jul 23, 2024
| await nonMutatingRequestTask.ConfigureAwait(false); | ||
| } | ||
| // If we had an exception, we want to record a NFW for it AND propogate it out to the queue so it can be handled appropriately. | ||
| catch (Exception ex) when (FatalError.ReportAndPropagateUnlessCanceled(ex, ErrorSeverity.Critical)) |
There was a problem hiding this comment.
i believe this is the correct pattern to report and throw, but let me know if not.
dibarbet
commented
Jul 23, 2024
| }); | ||
|
|
||
| var didReport = false; | ||
| FatalError.OverwriteHandler((exception, severity, dumps) => |
There was a problem hiding this comment.
tests to verify NFW handler is called for mutating and non-mutating requests
dibarbet
force-pushed
the
fix_shutdown_error
branch
from
046213b
to
f2bc949
Compare
dibarbet
force-pushed
the
fix_shutdown_error
branch
from
f2bc949
to
bb279fd
Compare
JoeRobich
approved these changes
Aug 14, 2024
This was referenced Aug 21, 2024
dibarbet
added a commit
that referenced
this pull request
Nov 15, 2024
…ve async listener in queue (#75907) Should resolve https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2224584 Optprof web application tests have been failing for a while in VS. Tim tracked down the issue to an async listener introduced in #74530 The never completing listener were requests for workspace diagnostics. This is actually expected for workspace diagnostics requests, as they are held open indefinitely if nothing changes (see https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/Protocol/Handler/Diagnostics/AbstractWorkspacePullDiagnosticsHandler.cs#L94). So as long as workspace diagnostics requests function this way, it is easy to get into a situation where there are async listeners that never complete. The queue async listener was introduced to ensure that unit tests could reliably verify if the NFW handler was called (as handling the exception happened after the response was returned to the client). To resolve this issue I did a couple things 1. Move reporting NFW for request exceptions into the telemetry reporting scope. Importantly this scope is called before the result is sent back to the client. This allows unit tests to simply wait for the request to complete before checking if the NFW handler was called (no need for an async listener). 2. Removing the async listener from the queue now that no unit tests need to wait for an action to occur in the queue. TODO - validate optprof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1922370
We were reporting connection lost exceptions when the server shutdown due to refresh notifications being sent during shutdown (they are triggered by events that are not a part of the shutdown handling in the queue).
This modifies the code to catch connection lost exceptions from refresh notifications. Other parts of the system already handle connection loss issues and report failures.
Additionally fixes an issue where we would not report NFW for mutating LSP requests.