Fix graying out of unused members in LSP #74589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@sharwell i cna't seem to figure out how to update the tests to pass. they seem to eb validating spans in strange ways. |
dibarbet
approved these changes
Jul 29, 2024
| @@ -3176,8 +3176,8 @@ class C | |||
| private C(int i) { } | |||
There was a problem hiding this comment.
Suggested change
| private C(int i) { } | |
| {|#0:private C(int i) { }|} |
There was a problem hiding this comment.
that doesn't seem to help.
| // /0/Test0.cs(3,13): info IDE0051: Private member 'C.C' is unused | ||
| VerifyCS.Diagnostic("IDE0051").WithSpan(3, 13, 3, 14).WithArguments("C.C")); | ||
| // /0/Test0.cs(3,13): info IDE0051: Private member 'C.C' is unused | ||
| VerifyCS.Diagnostic("IDE0051").WithSpan(3, 5, 3, 25).WithArguments("C.C")); |
There was a problem hiding this comment.
Suggested change
| VerifyCS.Diagnostic("IDE0051").WithSpan(3, 5, 3, 25).WithArguments("C.C")); | |
| VerifyCS.Diagnostic("IDE0051").WithLocation(0).WithArguments("C.C")); |
There was a problem hiding this comment.
that doesn't seem to fix things.
CyrusNajmabadi
commented
Jul 29, 2024
...nalyzers/Core/Analyzers/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jul 29, 2024
...nalyzers/Core/Analyzers/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 31, 2024
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_queries/edit/2086491