Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in AbstractStructureTaggerProvider.GetMultiLineRegions #74619

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Reduce allocations in AbstractStructureTaggerProvider.GetMultiLineRegions #74619

merged 2 commits into from
Jul 31, 2024

Commits on Jul 31, 2024

  1. Reduce allocations in AbstractStructureTaggerProvider.GetMultiLineReg… 

    …ions

This is a private method, and the caller simply enumerates the results, so there is no need to allocate an intermediary array.

This shows up as 0.6% of allocations in the scrolling speedomenter profile that I'm looking at (in the typing section of a particularly poorly performing run)
    @ToddGrun
    ToddGrun committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c827b23 View commit details
    Browse the repository at this point in the history

  2. Add comment for reasoning on why not using arraybuilder

    @ToddGrun
    ToddGrun committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c2980a3 View commit details
    Browse the repository at this point in the history