Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include App.config item only for net472 builds #74639

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Include App.config item only for net472 builds #74639

merged 1 commit into from
Aug 3, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 2, 2024 •
edited
Loading

Fixes intermittent build failures such as

44>InteractiveHost64 -> D:\github\roslyn\artifacts\bin\InteractiveHost64\Release\net472\win-x64\InteractiveHost64.exe
44>C:\Program Files\dotnet\sdk\9.0.100-preview.5.24307.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(355,5): 
error MSB3030: Could not copy the file "D:\github\roslyn\artifacts\obj\InteractiveHost64\Release\net472\win-x64\InteractiveHost64.exe.config" because it was not found.

@tmat tmat requested a review from a team as a code owner August 2, 2024 21:24
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 2, 2024
@tmat tmat enabled auto-merge (squash) August 2, 2024 22:03
@tmat tmat merged commit 1d4cdca into dotnet:main Aug 3, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 3, 2024
@tmat tmat deleted the FixConfig branch August 3, 2024 00:10
This was referenced Aug 7, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @JoeRobich @sharwell @dibarbet