Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite BulidSolution in Integration tests #74690

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Aug 8, 2024

In integration tests we depends on checking if the output contains
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ========== to decide if solution build passed.

I feel it's strange and I found another good way to do the check from IVsUpdateSolutionEvents

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 8, 2024
@Cosifne Cosifne marked this pull request as ready for review August 9, 2024 17:04
@Cosifne Cosifne requested a review from a team as a code owner August 9, 2024 17:04
@Cosifne Cosifne merged commit 02b281f into dotnet:main Aug 9, 2024
25 checks passed
@Cosifne Cosifne deleted the dev/shech/UpdateBuildSolution branch August 9, 2024 21:39
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 9, 2024
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants