Fix issues with VSCode LSP EA causing handlers to fail to load #74700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Aug 9, 2024
...ageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj
Show resolved
Hide resolved
dibarbet
commented
Aug 9, 2024
| @@ -14,8 +14,14 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.Xaml; | |||
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = false), MetadataAttribute] | |||
| internal sealed class ExportXamlLspServiceFactoryAttribute : ExportLspServiceFactoryAttribute | |||
| { | |||
| public ExportXamlLspServiceFactoryAttribute(Type type, WellKnownLspServerKinds serverKind = WellKnownLspServerKinds.Any) | |||
There was a problem hiding this comment.
this was the issue for XAML - exposing the enum as a default value.
dibarbet
commented
Aug 9, 2024
| : base(type, ProtocolConstants.RoslynLspLanguagesContract, serverKind) | ||
| { | ||
| } | ||
|
|
||
| public ExportXamlLspServiceFactoryAttribute(Type type) |
There was a problem hiding this comment.
@etvorun at some point once this change merges you'll want to update xaml to use this so Ican delete the old one.
JoeRobich
reviewed
Aug 9, 2024
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/ExportProviderBuilder.cs
Outdated
Show resolved
Hide resolved
JoeRobich
approved these changes
Aug 9, 2024
|
/azp run roslyn-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
333fred
approved these changes
Aug 9, 2024
|
Sorry! |
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2d311bd caused both @333fred 's compiler SDK extension and some XAML handlers to break.
This was caused due to the removal of the enum member, changing the numerical value of each. Code compiled against an older version of Roslyn that used the enum would be broken.
For the compiler SDK extension, this caused an issue because the enum was exposed in the EA library, which was being loaded from the extension (and not from roslyn). The fix is to ship and load the EA library from Roslyn (only 21kb).
For XAML, the LSP service factory exposed the enum as a default parameter, so all XAML LSP service factories had the wrong enum value. Xaml is updating their Roslyn version to fix, but here I also obsolete the API that exposed the enum (it wasn't necessary).
Also fixed an issue where MEF discovery errors werent being recorded.