-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IChecksummedObject type. #74829
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
243e6dc
Remove type
CyrusNajmabadi 1b934d6
Merge branch 'main' into checksummedObject
CyrusNajmabadi bd1dce2
Fallout
CyrusNajmabadi 26c6a96
remove
CyrusNajmabadi 03a22ae
Remove cancellationTokens
CyrusNajmabadi 5333ccc
Remove cancellationTokens
CyrusNajmabadi 4159630
Remove cancellationTokens
CyrusNajmabadi f4e3d4c
fix
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,11 +74,6 @@ public Checksum CreateChecksum(object value, CancellationToken cancellationToken | |
{ | ||
cancellationToken.ThrowIfCancellationRequested(); | ||
|
||
if (value is IChecksummedObject checksummedObject) | ||
{ | ||
return checksummedObject.Checksum; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. existed only to hijack. but we can already do that throuhg normal virtual methods. |
||
|
||
switch (kind) | ||
{ | ||
case WellKnownSynchronizationKind.CompilationOptions: | ||
|
@@ -89,10 +84,10 @@ public Checksum CreateChecksum(object value, CancellationToken cancellationToken | |
return Checksum.Create(value, this, cancellationToken); | ||
|
||
case WellKnownSynchronizationKind.MetadataReference: | ||
return CreateChecksum((MetadataReference)value, cancellationToken); | ||
return CreateChecksum((MetadataReference)value); | ||
|
||
case WellKnownSynchronizationKind.AnalyzerReference: | ||
return CreateChecksum((AnalyzerReference)value, cancellationToken); | ||
return CreateChecksum((AnalyzerReference)value); | ||
|
||
case WellKnownSynchronizationKind.SerializableSourceText: | ||
throw new InvalidOperationException("Clients can already get a checksum directly from a SerializableSourceText"); | ||
|
@@ -141,15 +136,15 @@ public void Serialize(object value, ObjectWriter writer, CancellationToken cance | |
return; | ||
|
||
case WellKnownSynchronizationKind.ProjectReference: | ||
SerializeProjectReference((ProjectReference)value, writer, cancellationToken); | ||
SerializeProjectReference((ProjectReference)value, writer); | ||
return; | ||
|
||
case WellKnownSynchronizationKind.MetadataReference: | ||
SerializeMetadataReference((MetadataReference)value, writer, cancellationToken); | ||
SerializeMetadataReference((MetadataReference)value, writer); | ||
return; | ||
|
||
case WellKnownSynchronizationKind.AnalyzerReference: | ||
SerializeAnalyzerReference((AnalyzerReference)value, writer, cancellationToken: cancellationToken); | ||
SerializeAnalyzerReference((AnalyzerReference)value, writer); | ||
return; | ||
|
||
case WellKnownSynchronizationKind.SerializableSourceText: | ||
|
@@ -274,8 +269,8 @@ public object Deserialize(WellKnownSynchronizationKind kind, ObjectReader reader | |
WellKnownSynchronizationKind.CompilationOptions => DeserializeCompilationOptions(reader, cancellationToken), | ||
WellKnownSynchronizationKind.ParseOptions => DeserializeParseOptions(reader, cancellationToken), | ||
WellKnownSynchronizationKind.ProjectReference => DeserializeProjectReference(reader, cancellationToken), | ||
WellKnownSynchronizationKind.MetadataReference => DeserializeMetadataReference(reader, cancellationToken), | ||
WellKnownSynchronizationKind.AnalyzerReference => DeserializeAnalyzerReference(reader, cancellationToken), | ||
WellKnownSynchronizationKind.MetadataReference => DeserializeMetadataReference(reader), | ||
WellKnownSynchronizationKind.AnalyzerReference => DeserializeAnalyzerReference(reader), | ||
WellKnownSynchronizationKind.SerializableSourceText => SerializableSourceText.Deserialize(reader, _storageService.Value, _textService, cancellationToken), | ||
WellKnownSynchronizationKind.SourceGeneratorExecutionVersionMap => SourceGeneratorExecutionVersionMap.Deserialize(reader), | ||
WellKnownSynchronizationKind.FallbackAnalyzerOptions => ReadFallbackAnalyzerOptions(reader), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't need to be on the itnerface. was never called externally.