-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade xUnit #75068
Merged
Merged
Upgrade xUnit #75068
Commits on Sep 25, 2024
-
One of our NuGet audit alerts was rooted in our xUnit packages as they only had `netstandard1.3` libraries. To resolve this alert I moved us to newer versions of the package which had `netstandard2.0` libraries. Upgrading the package revealed two problems in our code base: 1. The xUnit `Assert` APIs took advantage of the `unmanaged` constraint in a fwe places. That is not supported by Visual Basic and leads to errors on import. To work around this I inserted `AssertEx` thunks that our Visual Basic layer can call through. Longer term we will need to consider adding support for the constraint ([issue](dotnet#75063)) 2. The xUnit APIs significantly increased their nullable reference type annotations. This caught a number of places where the tests were passing potentially null values to APIs that don't accept null. There were enough hits that I added `AssertEx` methods that handle the nullable case. In a few places though I just suppressed the warning. The vulnerability: GHSA-cmhx-cq75-c4mj
Configuration menu - View commit details
-
Copy full SHA for 021f67c - Browse repository at this point
Copy the full SHA 021f67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96045bd - Browse repository at this point
Copy the full SHA 96045bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9228c15 - Browse repository at this point
Copy the full SHA 9228c15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02908cd - Browse repository at this point
Copy the full SHA 02908cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1adb8b - Browse repository at this point
Copy the full SHA e1adb8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db8f936 - Browse repository at this point
Copy the full SHA db8f936View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62ac904 - Browse repository at this point
Copy the full SHA 62ac904View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2af9e9 - Browse repository at this point
Copy the full SHA f2af9e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9c728a - Browse repository at this point
Copy the full SHA a9c728aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e45edb9 - Browse repository at this point
Copy the full SHA e45edb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d9ee0b - Browse repository at this point
Copy the full SHA 8d9ee0bView commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0d749b9 - Browse repository at this point
Copy the full SHA 0d749b9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.