Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xUnit #75068

Merged
merged 12 commits into from
Sep 26, 2024
Merged

Upgrade xUnit #75068

merged 12 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. Upgrade xUnit

    One of our NuGet audit alerts was rooted in our xUnit packages as they
    only had `netstandard1.3` libraries. To resolve this alert I moved us to
    newer versions of the package which had `netstandard2.0` libraries.
    
    Upgrading the package revealed two problems in our code base:
    
    1. The xUnit `Assert` APIs took advantage of the `unmanaged` constraint
       in a fwe places. That is not supported by Visual Basic and leads to
       errors on import. To work around this I inserted `AssertEx` thunks
       that our Visual Basic layer can call through. Longer term we will
       need to consider adding support for the constraint
       ([issue](dotnet#75063))
    2. The xUnit APIs significantly increased their nullable reference type
       annotations. This caught a number of places where the tests were
       passing potentially null values to APIs that don't accept null. There
       were enough hits that I added `AssertEx` methods that handle the
       nullable case. In a few places though I just suppressed the warning.
    
    The vulnerability: GHSA-cmhx-cq75-c4mj
    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    021f67c View commit details
    Browse the repository at this point in the history
  2. more

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    96045bd View commit details
    Browse the repository at this point in the history
  3. more

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9228c15 View commit details
    Browse the repository at this point in the history
  4. more

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    02908cd View commit details
    Browse the repository at this point in the history
  5. more

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e1adb8b View commit details
    Browse the repository at this point in the history
  6. see if this fixes the tests

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    db8f936 View commit details
    Browse the repository at this point in the history
  7. test fix

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    62ac904 View commit details
    Browse the repository at this point in the history
  8. fix overload

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f2af9e9 View commit details
    Browse the repository at this point in the history
  9. fixup for new xunit version

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a9c728a View commit details
    Browse the repository at this point in the history
  10. fix

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e45edb9 View commit details
    Browse the repository at this point in the history
  11. more

    jaredpar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8d9ee0b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Fix

    jaredpar committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0d749b9 View commit details
    Browse the repository at this point in the history