Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ResultId from RelatedDocumentsHandler #75176

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

genlu
Copy link
Member

@genlu genlu commented Sep 19, 2024

Because cursor position would impact the response from IRelatedDocumentsService

@genlu genlu requested a review from a team as a code owner September 19, 2024 20:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 19, 2024
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, probably some tests need to be updated

Because cursor position would impact the response from IRelatedDocumentsService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants