Improve error reporting when reading bad metadata during EnC #75304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
tmat
changed the title
tmat
force-pushed
the
EncDebugInfoReader
branch
from
2825b44
to
f1127ff
Compare
|
@davidwengier @dotnet/roslyn-compiler ptal |
davidwengier
approved these changes
Oct 1, 2024
AlekseyTs
reviewed
Oct 1, 2024
| @@ -690,7 +692,7 @@ static ImmutableArray<string> getHoistedVariableNames(ImmutableArray<ISymbolInte | |||
| { | |||
| provider = Baseline.DebugInformationProvider(MetadataTokens.MethodDefinitionHandle(methodRowId)); | |||
| } | |||
| catch (Exception e) when (e is InvalidDataException or IOException) | |||
| catch (Exception e) when (e is InvalidDataException or IOException or BadImageFormatException) | |||
There was a problem hiding this comment.
It's not a critical error. If a method is deleted and its body is not updated to throw an exception it would execute the original IL. Perhaps we could add a new warning but I don't think it's worth the effort.
cston
approved these changes
Oct 1, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps diagnosing issues like #65176