-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "propr" snippet for required properties #75339
Conversation
src/Features/CSharpTest/Snippets/AbstractCSharpAutoPropertySnippetProviderTests.cs
Show resolved
Hide resolved
src/Features/Core/Portable/Snippets/CommonSnippetIdentifiers.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/AbstractCSharpAutoPropertySnippetProviderTests.cs
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/CSharpProprSnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Snippets/AbstractCSharpAutoPropertySnippetProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Snippets/AbstractCSharpAutoPropertySnippetProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Snippets/CSharpProprSnippetProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Snippets/CSharpProprSnippetProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/AbstractCSharpAutoPropertySnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/AbstractCSharpAutoPropertySnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/CSharpProprSnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/CSharpProprSnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Snippets/CSharpProprSnippetProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/AbstractCSharpAutoPropertySnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/CSharpProprSnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharpTest/Snippets/CSharpPropSnippetProviderTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My opinion doesn't count really, but I expect a lot less feedback from the team member now. @victor-pogor You may resolve all leftover feedback items from me. Thanks for great work!
@akhera99 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @victor-pogor for the contribution and @DoctorKrolic for reviewing!
closes #75128
I have checked what modifiers are allowed and limited the
propr
snippet to the valid cases:propr.mp4