Reduce allocations during typing #75351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During typing, various codepaths attempt to find the set of changes between two text images. Note that while this change will get rid of the allocations, I'm not certain it makes sense for that codepath to be getting executed so frequently and am following up elsewhere.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Oct 2, 2024
333fred
approved these changes
Oct 2, 2024
|
@dotnet/roslyn-compiler for 2nd review |
Youssef1313
reviewed
Oct 3, 2024
Comment on lines
+27
to
+29
| var newChange = changesInNextVersion.Count == 1 | ||
| ? changesInNextVersion[0] | ||
| : TextChangeRange.Collapse(changesInNextVersion); |
There was a problem hiding this comment.
Should this optimization be moved inside TextChangeRange.Collapse itself?
There was a problem hiding this comment.
I considered that, but that method has several usages in which the caller only has an IEnumerable. I instead chose to limit the changes to the caller that was showing up in the performance profile I was looking at.
jjonescz
approved these changes
Oct 3, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During typing, various codepaths attempt to find the set of changes between two text images. Note that while this change will get rid of the allocations, I'm not certain it makes sense for that codepath to be getting executed so frequently and am following up elsewhere. This should reduce allocations in the profile that I'm looking at by around 1.4% during typing.
*** allocations from the typing scenario in the new csharp editing speedometer that should be alleviated **
