Navigate to the mapped span when navigating to a mapped file #75460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Comment on lines
230
to
231
| var getMappedVsTextSpan = (SourceText sourceText) => getVsTextSpanForMapping(sourceText, mappedSpan.Span); | ||
| return GetNavigationCallback(documentIdToNavigate, workspace, getMappedVsTextSpan); |
There was a problem hiding this comment.
Suggested change
| var getMappedVsTextSpan = (SourceText sourceText) => getVsTextSpanForMapping(sourceText, mappedSpan.Span); | |
| return GetNavigationCallback(documentIdToNavigate, workspace, getMappedVsTextSpan); | |
| return GetNavigationCallback( | |
| documentIdToNavigate, | |
| workspace, | |
| sourceText => getVsTextSpanForMapping(sourceText, mappedSpan.Span)); |
|
Going to trust that thsi works :D |
CyrusNajmabadi
approved these changes
Oct 10, 2024
This was referenced Oct 22, 2024
davidwengier
added a commit
that referenced
this pull request
Nov 14, 2024
Follow up to #75460 Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2288477 When I looked at the code I thought "Who would want to map a span, and then not use the mapped span?!". Turns out the answer is "aspx files".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#2136046
Roslyn was helpfully mapping to a file, but then trying to navigate to the unmapped span. This fixes that, and allows the mapped file to be an AdditionalDocument rather than just a Document.
I couldn't find any tests that specifically covered this, but let me know if I missed them somewhere.