Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/dev17.12] EE: Handle notification when metadata has been invalidated (#75423) #75518

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

cston
Copy link
Member

@cston cston commented Oct 15, 2024

Port #75423 to release/dev17.12.

Implement notification interface in the EE to ensure assembly metadata is discarded before being invalidated.

cc @jaredpar, @gregg-miskelly

@cston cston requested review from a team as code owners October 15, 2024 20:46
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 15, 2024
@@ -64,7 +64,7 @@
<PackageVersion Include="Microsoft.VisualStudio.Extensibility" Version="$(MicrosoftVisualStudioExtensibilityVersion)" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.Sdk" Version="$(MicrosoftVisualStudioExtensibilityVersion)" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.JsonGenerators.Sdk" Version="$(MicrosoftVisualStudioExtensibilityVersion)" />
<PackageVersion Include="Microsoft.VSSDK.Debugger.VSDConfigTool" Version="17.0.1051901-preview" />
<PackageVersion Include="Microsoft.VSSDK.Debugger.VSDConfigTool" Version="17.13.1100801-preview" />
Copy link
Member Author

@cston cston Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package versions for the debugger packages should be updated to 17.12.* rather than 17.13.* once those packages are available. Marking the PR as BLOCKED until then. #Resolved

@cston cston added the Blocked label Oct 15, 2024
@cston cston changed the title EE: Handle notification when metadata has been invalidated (#75423) [release/dev17.12] EE: Handle notification when metadata has been invalidated (#75423) Oct 15, 2024
@cston cston requested a review from a team October 15, 2024 20:51
@cston cston removed the Blocked label Oct 18, 2024
@cston
Copy link
Member Author

cston commented Oct 18, 2024

@jaredpar, @dotnet/roslyn-compiler, please review, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants