Avoid unnecessary tail increment in collection expressions codegen #75559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
RikkiGibson
approved these changes
Oct 18, 2024
| System.Runtime.CompilerServices.TaskAwaiter<int[]> V_6, | ||
| System.Span<int> V_7, | ||
| System.Exception V_8) | ||
| int V_4, |
There was a problem hiding this comment.
This seems like a nice little win. It looks like the local is no longer being lifted into a display class because now it is not used after the await.
cston
approved these changes
Oct 21, 2024
|
Thanks @DoctorKrolic. |
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #74875
Replacement for #74982 (got some complicated merge conflicts due to the merge of a new feature branch, so I decided that it would be easier to redo this from scratch)
Existing tests cover both array and span code paths in various configurations (just scalar elements or the last scalar after spread), so no new tests are necessary