Field-backed properties: recognize field in interpolated string #75566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
333fred
reviewed
Oct 20, 2024
333fred
approved these changes
Oct 21, 2024
jaredpar
reviewed
Oct 22, 2024
| @@ -377,6 +378,7 @@ private static InterpolationSyntax ParseInterpolation( | |||
|
|
|||
| // Now create a parser to actually handle the expression portion of the interpolation | |||
| using var tempParser = new LanguageParser(tempLexer, oldTree: null, changes: null); | |||
| using var __ = new FieldKeywordContext(tempParser, isInFieldKeywordContext); | |||
There was a problem hiding this comment.
var __ was used for the other location in the parser to avoid conflicting with out _. Updated here.
jjonescz
approved these changes
Oct 23, 2024
| var verifier = CompileAndVerify(comp, verify: Verification.Skipped, expectedOutput: IncludeExpectedOutput(""" | ||
| P1: True | ||
| 2 | ||
| """)); |
There was a problem hiding this comment.
Consider calling verifier.VerifyDiagnostics. Applies to the tests below as well.
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse
fieldas a keyword when used in an interpolated string in an accessor.See dotnet/csharplang#140 (comment)