Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate spread suppression #75596

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Propagate spread suppression #75596

merged 2 commits into from
Oct 25, 2024

Conversation

jjonescz
Copy link
Member

Fixes #75560.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 23, 2024
@jjonescz jjonescz marked this pull request as ready for review October 23, 2024 13:09
@jjonescz jjonescz requested a review from a team as a code owner October 23, 2024 13:09
@jjonescz jjonescz requested a review from a team October 24, 2024 08:23
AlekseyTs
AlekseyTs reviewed Oct 24, 2024
View reviewed changes
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
using System.Collections.Generic;
IEnumerable<object?> a = [null];
object[] b = [..a];
object[] c = [..a!];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

I would strengthen the tests and used a different local here in order to avoid a chance that the error was not reported here because it was reported for the same local on the previous line.

AlekseyTs
AlekseyTs approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jjonescz jjonescz enabled auto-merge (squash) October 25, 2024 08:12
@jjonescz jjonescz merged commit 2c34771 into dotnet:main Oct 25, 2024
24 checks passed
@jjonescz jjonescz deleted the 75560-SpreadNullSuppression branch October 25, 2024 11:02
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 25, 2024
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
This was referenced Oct 29, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.

! does not suppress nullable warning from spread element type
4 participants
@jjonescz @AlekseyTs @cston @akhera99