Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configs for 17.13p2 snap #75650

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

akhera99
Copy link
Member

Draft until snap time

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 28, 2024
"nugetKind": [
"Shipping",
"NonShipping"
],
"vsBranch": "main",
"vsMajorVersion": 17,
"insertionCreateDraftPR": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would prefer to leave this in so I don't have to think about what the default is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff is misleading, it's still in for main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, think I see what you mean, we generally don't put this flag for release branches.

@akhera99 akhera99 marked this pull request as ready for review October 28, 2024 22:20
@akhera99 akhera99 requested a review from a team as a code owner October 28, 2024 22:20
@RikkiGibson RikkiGibson merged commit 502d0ec into dotnet:main Oct 28, 2024
2 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 28, 2024
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants