Improve pattern matching when user is likely providing camel humps #75757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Nov 5, 2024
| comparison = (!this.IsCaseSensitive).CompareTo(!other.IsCaseSensitive); | ||
| if (comparison != 0) | ||
| return comparison; | ||
| switch (this.IsCaseSensitive, other.IsCaseSensitive) |
There was a problem hiding this comment.
same as before. just clearer imo.
genlu
reviewed
Nov 5, 2024
| @@ -170,15 +182,31 @@ private static bool ContainsUpperCaseLetter(string pattern) | |||
| } | |||
| else | |||
| { | |||
| var isCaseSensitive = _compareInfo.IsPrefix(candidate, patternChunk.Text); | |||
There was a problem hiding this comment.
no. This is stating if it's case sensitive or not. if it's a prefix that it is, otherwise it isn't and it must have been case inseisitive.
genlu
reviewed
Nov 5, 2024
| // See if we can find a camel case match. | ||
| if (candidateHumps.Count == 0) | ||
| StringBreaker.AddWordParts(candidate, ref candidateHumps.AsRef()); | ||
| { |
There was a problem hiding this comment.
this code block looks a bit confusing
There was a problem hiding this comment.
not sure what to do about that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17275