Classify 'await' as a control keyword #75782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Nov 6, 2024
| @@ -16,7 +16,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Nov 6, 2024
| var actualFormatted = actualOrdered.Select(a => new FormattedClassification(allCode.Substring(a.TextSpan.Start, a.TextSpan.Length), a.ClassificationType)); | ||
| AssertEx.Equal(expected, actualFormatted); | ||
| var actualFormatted = actualOrdered.SelectAsArray(a => new FormattedClassification(allCode.Substring(a.TextSpan.Start, a.TextSpan.Length), a.ClassificationType)); | ||
| AssertEx.Equal(expected.ToImmutableArray(), actualFormatted); |
There was a problem hiding this comment.
this improves the diff view as the immutablearray overload produces a better diff.
CyrusNajmabadi
commented
Nov 6, 2024
| case SyntaxKind.DoKeyword: | ||
| case SyntaxKind.SwitchKeyword: | ||
| case SyntaxKind.AwaitKeyword: | ||
| case SyntaxKind.BreakKeyword: |
There was a problem hiding this comment.
sorted just for clarity. the only other hcange is adding the .AwaitKeyword entry.
CyrusNajmabadi
commented
Nov 6, 2024
| case SyntaxKind.SwitchStatement: | ||
| case SyntaxKind.SwitchSection: | ||
| case SyntaxKind.CaseSwitchLabel: | ||
| case SyntaxKind.AwaitExpression: | ||
| case SyntaxKind.CasePatternSwitchLabel: |
There was a problem hiding this comment.
sorted for clarity. the only other change was adding .AwaitExpression
dibarbet
approved these changes
Nov 6, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40741
Can skip second commit.