Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running lightbulbs even when not fully loaded. #75869

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Nov 12, 2024

We used to have this block as we could not actually make changes to the workspace while it was loading. Specifically, any application of the fix was normally doomed to fail as the workspace version would have changed out from underneath us, and we would immediately bail.

That restriction was lifted a long time ago. Now, lightbulbs can apply to the workspace, as long as the file contents of the file they are applying to has not changed. As such, this restriciton can be removed.

This is also really desirable as we have a lot of high-pri fixers taht you want to run, even if things like project restore haven't happened yet. For example, imagine this scenario:

  1. You do a large git operation, changing tons of files.
  2. A bunch of files have merge conflicts in them.
  3. You open VS to go fix the merge conflicts.
  4. You are blocked on that because a project-system restore needs to happen first, despite us having the information necessary to add the lightbulb actions to fix merge conflicts.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 12, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review November 12, 2024 19:02
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants