Merge main into VBOverloadResolutionPriority #75955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…baseline update (#75934)
* Add runtime async design doc Adding an initial design document for runtime async. I'm not making a branch for this yet so I don't have to worry about keeping it up to date until we're actually ready to start implementation work; that should begin soon, but I think getting this document into `main` and starting collaboration with the runtime and debugger folks will help that proceed. * Remove incorrect IL steps * Add more examples and updates the runtime document. * Add another open question * Add more translated C# samples * Feedback and more scenarios * Remove PR link * Add note about potential hoisted local cleanup
Inspired by a test in #75862.
Client side PR - dotnet/vscode-csharp#7791 Implements support for refreshing source generated files provided by LSP. Refresh notifications are sent to the client based on workspace changes that may affect source generated files. To handle the overreporting of refresh notifications, I also implemented resultId based support in the get text handler - it will now avoid re-sending the entire text to the client if nothing has changed. 
…ions from VS shell (#75815) * Reduce IVsFreeThreadedFileChangeEvents2.DirectoryChangedEx2 notifications from VS shell While looking into another FileWatcher issue, I noticed that we were getting more notifications from shell on directory changes than I would have expected. It turns out this is because we don't currently combine WatchDirectory operations as we do WatchFile/UnwatchFile/UnwatchDirectories. This is generally the desired behavior as vs shell doesn't support multiple directories being supported by a single notification. However, they do support multiple filters on the same directory, and this is exactly the case that we usualy experience when processing a batch of WatcherOperations. This PR simply allows combining of directory watch notifications for the same directory (and sink), keeping track of the combined set of filters that all requests had. Note that this PR also changed the mergability of WatchFiles by only allowing merging if the sinks are the same. I don't have context to be completely confident the prior behavior is a bug, but it sure seems wrong.
…tion of textchanges (#75928) * Send over the new sourcetext's content checksum when sending notification of textchanges Calculation of this on the server was taking quite a bit of CPU (about 11.6% in the scrolling speedometer during the typing scenario). Instead, pass this data over as part of the text change notification, similar to what SerializableSourceText's serialization does.
Co-authored-by: Omar Bonnet <[email protected]>
dotnet-issue-labeler
bot
added
the
untriaged
cston
approved these changes
Nov 18, 2024
AlekseyTs
merged commit 0367368
into
features/VBOverloadResolutionPriority
25 of 28 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.