Update 'implement interface' to forward explicit members to implicit ones #76044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
Nov 25, 2024
| { | ||
| get | ||
| { | ||
| return Current; |
There was a problem hiding this comment.
This is "fine". it's the legacy apis calling to the modern ones.
ToddGrun
reviewed
Nov 25, 2024
| @@ -209,12 +213,27 @@ public static ImmutableArray<SyntaxNode> GetGetAccessorStatements( | |||
| return [generator.ReturnStatement(expression)]; | |||
| } | |||
|
|
|||
| return preferAutoProperties ? default : generator.CreateThrowNotImplementedStatementBlock(compilation); | |||
| if (preferAutoProperties) | |||
There was a problem hiding this comment.
honestly. i'm really trying to hit the sweet spot here.
ToddGrun
reviewed
Nov 25, 2024
...rkspaces/SharedUtilitiesAndExtensions/Workspace/Core/Extensions/SyntaxGeneratorExtensions.cs
Outdated
Show resolved
Hide resolved
Not from this PR, but should the "value" string be changed on line 252 too? Refers to: src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/Extensions/SyntaxGeneratorExtensions.cs:265 in 0052955. [](commit_id = 0052955, deletion_comment = True) |
Caring level is low. I'm focusing on issues peoplee report. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67023